Copy on Write #110
Open
Copy on Write #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jamierpond
commented
Apr 29, 2025
jamierpond
commented
- Comments
- string io affordance working
- works
- update copy
- copy on write tests pass
| } | ||
|
|
||
| auto makeExclusive() { | ||
| *sharedPointer() = std::make_shared<V>(*value()); |
There was a problem hiding this comment.
Not that this would be an issue for the vast majority of cases, but maybe const qualify the lvalue reference so it always selects the copy constructor.
Suggested change
| *sharedPointer() = std::make_shared<V>(*value()); | |
| *sharedPointer() = std::make_shared<V>(static_cast<const V &>(*value())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.